search

etcdv3 / etcd-client

An etcd v3 API client
Apache License 2.0
210 stars 51 forks source link

Update tonic to 0.11 #75

Closed yotamofek closed 5 months ago

yotamofek commented 9 months ago

This raises the MSRV to 1.70, so probably warrants a minor release, though I don't think etcd-client actually specifies an MSRV.

MichaelScofield commented 7 months ago

@yotamofek @davidli2010 any updates?

davidli2010 commented 7 months ago

I'm waiting for https://github.com/hyperium/tonic/pull/1670.

tiagolobocastro commented 5 months ago

I'm waiting for hyperium/tonic#1670.

That seems like a huge change in tonic... Perhaps might be more conservative to update to 0.11 first, and then the big one later on?

davidli2010 commented 5 months ago

I'm waiting for hyperium/tonic#1670.

That seems like a huge change in tonic... Perhaps might be more conservative to update to 0.11 first, and then the big one later on?

Is tonic 0.11badly needed?

tiagolobocastro commented 5 months ago

Is tonic 0.11badly needed?

Not that badly needed for me tbh, just a would be good to have to keep same tonic version in my project. Maybe @yotamofek has more needs?

yotamofek commented 5 months ago

Is tonic 0.11badly needed?

Not that badly needed for me tbh, just a would be good to have to keep same tonic version in my project. Maybe @yotamofek has more needs?

Same here, just trying to minimize duplicated dependencies in my Cargo.lock. I think https://github.com/hyperium/tonic/pull/1670 still has some time before it's merged, IMHO it would be nice to have an interim release of etcd-client in the meantime.