New HN layout/features breaks HNES

etcet / HNES

Hacker News Extension Suite

Other

248 stars 71 forks source link

New HN layout/features breaks HNES #117

Closed c17r closed 4 years ago

c17r commented 8 years ago

HN announcement: https://news.ycombinator.com/item?id=12073675

When looking at the comments page:

HNES version of collapse/expand no longer shows
HNES highlighting of new comments no longer shows
Story text and top-level comment box shoved flush right
Going to https://news.ycombinator.com/threads?id=_username_ shows a blank page

ibejoeb commented 8 years ago

Yes, they implemented the persistent collapsible comments. Interesting, because I just had a conversation with them last week about ongoing development of the extension...

c17r commented 8 years ago

In one of the threads dang mentioned they are considering the "highlighting of new comments" as a core feature as well.

ibejoeb commented 8 years ago

I have a new branch that actually does not break, but the presentation is a little wonky. I've been working through some of the features, and new-comment highlighting is next.

ibejoeb commented 8 years ago

Seems like dang is saying they're adding new-comment highlighting directly.

https://news.ycombinator.com/item?id=12073934

c17r commented 8 years ago

Hence my comment above 😄

ibejoeb commented 8 years ago

Misunderstood, thought you were talking about unfulfilled request.

etcet commented 8 years ago

I've fixed the item and threads pages in https://github.com/etcet/HNES/commit/2041f92c9623afbb746a48e7b938c8a5695ce038. I think there's just fixing favorites (https://github.com/etcet/HNES/issues/120) and perhaps testing the performance of the new collapse and use whichever is best. It may make more sense to use the new functionality and drop ours.

c17r commented 8 years ago

I'd probably stick to using the native collapse instead of HNES but would move it from the right side of the name to the left.