"o" shortcut opens /undefined instead of page

[kotoole1]

After selecting a row with the j/k keys, the "o" key is supposed to open the link (like the "c" key opens the comments).

As of a few months ago, instead the shortcut opens https://news.ycombinator.com/undefined, a page which just contains the word "unknown."

Happens in chrome, both windows and mac versions.

[chaseha]

Same issue has broken the other keyboard shortcuts that open links ("l", "b")

Keyboard navigation was the main benefit of this extension, IMO. Any forks that fix this?

[kotoole1]

https://github.com/etcet/HNES/pull/186

It's a one-line fix, let's see if @etcet is still alive enough to click merge. Would rather not hard fork.

[etcet]

I'm alive enough to click merge but publishing to the web stores will need to wait until after the holidays

[chaseha]

Sounds good - thank you both!

On Wed, Dec 21, 2022 at 3:11 PM Chris James @.***> wrote:

I'm alive enough to click merge but publishing to the web stores will need to wait until after the holidays

— Reply to this email directly, view it on GitHub https://github.com/etcet/HNES/issues/185#issuecomment-1362038483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7QFWQ4AD75VERNOR23NOTWONQA5ANCNFSM6AAAAAAR7FJLR4 . You are receiving this because you commented.Message ID: @.***>

[kotoole1]

Excellent, thank you very much!

[etcet]

I've submitted the extension for review on firefox and chrome web store, thanks for the fix @kotoole1