Fixed topcolor setting

[sglantz]

Fixes issue #52 in which the HN topcolor setting was ignored by HNES.

There are two issues with this feature that we might want to address in a future update. Just like the vanilla HN topcolor, the text on the menu can still become unreadable if there isn't enough contrast between the color chosen and the default white and black text. Considering this is an enhancement suite, a nice additional feature would be to add some logic to adjust the primary and alternate text colors so that both are readable on the selected background. Secondly, the HNES nav drop menus used the same #d74937 that will be replaced if a topcolor is selected. While I could certainly see arguments for the contrary, I decided to keep it simple and not change the nav menu to match the topcolor. This could be changed in a future update if there is a demand.

[jzelinskie]

Any news on this PR landing? It's been months.

[etcet]

I'm sorry for the delay. I have 239 karma right now so I can't yet test this patch. I'll try to get 11 more this week so I can test this.

[jzelinskie]

No need to apologize -- I was just curious since you hadn't commented yet.

[yock]

@etcet Do you need some help testing these features? I have plenty of karma to test most things, and as someone who uses this extension quite a bit I'd be eager to help getting these features and fixes out the door.

[etcet]

I'm just terrible at commenting and getting karma. I'd love some help testing. I'm going to commit this as is and make sure it doesn't break anything for me - speak up if anything breaks for you.

[jzelinskie]

The only caveat appears to be that these menus are not also colored.

[etcet]

This should be fixed in commit bebecbad9e1888b7a082cde9696867857e651f06 and available in version 1.3.4.8