#56 - Move search into top bar behind a show / hide.

etcet / HNES

Hacker News Extension Suite

Other

248 stars 71 forks source link

#56 - Move search into top bar behind a show / hide. #72

Closed JoshSchreuder closed 1 year ago

JoshSchreuder commented 9 years ago

I took another crack at it basing off @nfvs's attempt. I put it behind a focus / blur show/hide though. I think I like it a bit better than having a persistent search bar in the header.

I also changed the search placeholder text to use the more semantic 'placeholder' property on the field rather than custom hacking it using events. The functionality to disable shortcuts when focused in the field was preserved.

Hope you like it.

nfvs commented 9 years ago

I think it looks great! A couple of comments:

When you click and the search input expands, the whole search+user+score cell seems to move slightly up, which can be annoying;
Might make sense to bind the escape key to "hide" the input box and restore the initial state.

etcet commented 1 year ago

I'm sorry, I don't have the time or effort for this project anymore.