search

etchteam / storybook-addon-css-variables-theme

Change the CSS variable based design tokens in your storybook on the fly
MIT License
28 stars 12 forks source link

feat: remove "no theme" option when defaultTheme is defined #17

Closed mihkeleidast closed 2 years ago

mihkeleidast commented 2 years ago

Resolves #16.

An alternative that could be considered is to remove the "No theme" option internally completely, and allow consumers to define it as 'No theme': null, as one of the options. But I suspect in most cases when defaultTheme is suggested, a no theme option is not expected.

The rest of the whitespace changes came from prettier (I have autoformat on save enabled in my editor) - I can revert those, if necessary, but maybe there should be some enforcement of the prettier code style instead.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gavmck commented 2 years ago

Out on 1.2.1, thanks!

BkSouX commented 2 years ago

great !