etchteam / storybook-addon-css-variables-theme

Change the CSS variable based design tokens in your storybook on the fly
MIT License
28 stars 12 forks source link

Switching Theme Via Url Params #46

Closed alijah-etch closed 1 year ago

alijah-etch commented 1 year ago

Switches theme from url words separated by --

gavmck commented 1 year ago

I think the only thing that bugs me in the -- separator, this seems like unnecessary extra overhead. Why does it do this?

alijah-etch commented 1 year ago

It's to account for spacing in Theme names

gavmck commented 1 year ago

It's to account for spacing in Theme names

You can use spaces in the query string though ?theme=dark theme is valid

alijah-etch commented 1 year ago

You can use spaces in the query string though ?theme=dark theme is valid

I changed it to be done with just spaces or preferred %20 which is more consistent

gavmck commented 1 year ago

Thanks!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information