search

etcimon / libasync

Cross-platform event loop library of asynchronous objects
MIT License
147 stars 30 forks source link

Clean up for druntime 2.071 #57

Closed MoritzMaxeiner closed 8 years ago

MoritzMaxeiner commented 8 years ago

Remove everything that is shipped with druntime 2.071. Sadly, there still seem to be some things (like SO_REUSEPORT) to be missing (meaning this module is not yet obsolete).

wilzbach commented 8 years ago

Wow removing 1.1K lines. That's a great cleanup! But doesn't this mean you temporarily loose ldc stable support? Afaict the latest ldc version ships with 2.071, but it's still in beta.

etcimon commented 8 years ago

For backwards compatibility it would probably require a __VERSION__ >= 2071 at first, I use 2.070 myself still because my production-level project isn't ready for 2.071 yet due to some regressions in win64 that I haven't addressed yet

etcimon commented 8 years ago

It's possible that this would work with 2.070, I'd have to check

MoritzMaxeiner commented 8 years ago

$ dub test --compiler=ldc2 runs fine for me, so I believe they may have been added earlier. I'll have a look.

etcimon commented 8 years ago

Oh I completely forgot that the unit tests covered all the way down to 2.068. OK Thanks for this!