search

etcimon / libasync

Cross-platform event loop library of asynchronous objects
MIT License
147 stars 30 forks source link

Fix compilation on OS X #59

Closed MoritzMaxeiner closed 8 years ago

MoritzMaxeiner commented 8 years ago

I assume this to be correct (after reading the other kill routines), but you might want to double-check.

etcimon commented 8 years ago

The hickup here is whether I want to pass ownership of the descriptor. Maybe there should be a detach() as well, this would be used mostly for raw sockets e.g. netlink, although I haven't yet tested.

On the other hand, the windows implementation is a no-op currently, I should give it assert(false) for now.

MoritzMaxeiner commented 8 years ago

I'm not deep into the internals of the OS APIs libasync uses, this was just to get it to compile again. If you think it's wrong, my apologies.

etcimon commented 8 years ago

Ok Thanks