etcinit / phabulous

A Phabricator bot for Slack
MIT License
218 stars 47 forks source link

Some feed events are failing to return 200 #50

Closed A-Tran closed 6 years ago

A-Tran commented 7 years ago

Initially noticed some strange behavior where certain feed events were showing up in the channel multiple times. This is caused by Phabricator's behavior which will continue to retry if it doesn't receive a 200 when the event is posted. However, it seems that the error is happening after the message goes through to slack, since we are seeing duplicate messages.

This is what we get while monitoring phabulous in debug mode:

2017/02/01 17:41:10 Panic recovery -> runtime error: index out of range
/usr/local/Cellar/go/1.5.1/libexec/src/runtime/panic.go:423 (0x806f34d)
/usr/local/Cellar/go/1.5.1/libexec/src/runtime/panic.go:12 (0x806dc93)
/Users/etcinit/go/src/github.com/etcinit/phabulous/app/resolvers/differential.go:47 (0x81e1236)
/Users/etcinit/go/src/github.com/etcinit/phabulous/app/controllers/feed.go:90 (0x815ff47)
/Users/etcinit/go/src/github.com/etcinit/phabulous/app/controllers/feed.go:29 (0x8160c78)
/Users/etcinit/go/src/github.com/gin-gonic/gin/context.go:95 (0x8161099)
/Users/etcinit/go/src/github.com/gin-gonic/gin/logger.go:56 (0x816ec7f)
/Users/etcinit/go/src/github.com/gin-gonic/gin/context.go:95 (0x8161099)
/Users/etcinit/go/src/github.com/gin-gonic/gin/recovery.go:43 (0x816f5ea)
/Users/etcinit/go/src/github.com/gin-gonic/gin/context.go:95 (0x8161099)
/Users/etcinit/go/src/github.com/gin-gonic/gin/gin.go:294 (0x8166603)
/Users/etcinit/go/src/github.com/gin-gonic/gin/gin.go:275 (0x81662fe)
/usr/local/Cellar/go/1.5.1/libexec/src/net/http/server.go:1862 (0x81fbbb6)
/usr/local/Cellar/go/1.5.1/libexec/src/net/http/server.go:1361 (0x81f9905)
/usr/local/Cellar/go/1.5.1/libexec/src/runtime/asm_386.s:1662 (0x8097d61)
schemar commented 6 years ago

I assume this will be fixed in the upcoming release. Please re-open if you still have the issue with 3.0.0