Closed mitali31 closed 6 years ago
Merging #56 into master will decrease coverage by
10.12%
. The diff coverage is14.28%
.
@@ Coverage Diff @@
## master #56 +/- ##
===========================================
- Coverage 27.25% 17.13% -10.13%
===========================================
Files 17 24 +7
Lines 521 893 +372
===========================================
+ Hits 142 153 +11
- Misses 378 739 +361
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
app/modules/core/command_task.go | 0% <0%> (ø) |
|
app/modules/core/module.go | 0% <0%> (ø) |
|
app/connectors/common.go | 100% <100%> (ø) |
:arrow_up: |
app/modules/core/command_lookup.go | 11.62% <17.39%> (ø) |
|
app/controllers/front.go | 0% <0%> (ø) |
:arrow_up: |
app/engine.go | 100% <0%> (ø) |
:arrow_up: |
app/modules/core/command_modules.go | 0% <0%> (ø) |
|
app/modules/core/command_summon.go | 0% <0%> (ø) |
|
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aa862c4...d839a0e. Read the comment docs.
@mitali31 first of all sorry that no one replied to you for so long!
Is this PR still relevant? If so can you please rebase on the latest master
?
Thanks!
Yep, it's still relevant.
Thank you @mitali31! Something went wrong when you rebased, so that the changes from master
are now listed in the diff. Can you please re-create the PR so that only your changes are listed?
Furthermore, can you please add tests so that your code is covered at least up to the specified target? That would be very nice.
Thank you!
Sounds good. I'll close this and put up a new PR.
Thanks!
Thank you!
'listtasks' command has the following properties: