search

etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.
https://etclabscore.github.io/core-geth
GNU Lesser General Public License v3.0
268 stars 147 forks source link

Merge/foundation release/1.11 rm other client configs #535

Closed meowsbits closed 1 year ago

meowsbits commented 1 year ago

Resolving a TODO at this comment. Merge base: https://github.com/etclabscore/core-geth/pull/531

This PR proposed removing support for configuration data types of MultiGeth, OpenEthereum/Parity, Aleth, and Pythereum. Only the first two were well supported at core-geth anyways, but all have become disused in some way and supporting configuration interchange with them just doesn't make that much sense anymore. For example, since about Istanbul new EIPs have not been supported, so the data type was basically a stand-in anyways.

meowsbits commented 1 year ago

Heads up on https://github.com/etclabscore/core-geth/pull/535/commits/07eff873d2d09e9db927797cb1e5da3c8eba5b8b; the test was passing for unknown reasons, but this should hopefully prevent it from failing for unknown reasons, too.

Resolving https://github.com/etclabscore/core-geth/pull/535#pullrequestreview-1381375856.