Merge/foundation release/1.12.2+spiral

etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.

https://etclabscore.github.io/core-geth

GNU Lesser General Public License v3.0

267 stars 147 forks source link

Merge/foundation release/1.12.2+spiral #561

Closed meowsbits closed 1 year ago

meowsbits commented 1 year ago

Implements the pending Spiral (ECIP-1109) network upgrade for ETC.

ziogaschr commented 1 year ago

Oh actually, before we merge this, shall we set the block numbers for Spiral correctly? Currently classic is set to 18_400_000, while Mordor is not at all.

meowsbits commented 1 year ago

Ah, important. I think we should unset all activation numbers for ETC until the ECIP gets more love and confidence. (ECIP 1109 currently specs impossible (past) values of 18000000 for mainnet, 9000000 for Mordor); https://github.com/ethereumclassic/ECIPs/blob/64423c73b7416c2f8e40d4c66bf40b715c458b8c/_specs/ecip-1109.md).

meowsbits commented 1 year ago

Test was failing, but is another flaky one https://github.com/etclabscore/core-geth/actions/runs/6084737553/job/16507292035?pr=561#step:4:1218. Cannot reproduce locally. Merging.