search

etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.
https://etclabscore.github.io/core-geth
GNU Lesser General Public License v3.0
267 stars 147 forks source link

Update and rename configurator_test.go to configurator_2test.go #573

Closed quantumtechniker closed 9 months ago

quantumtechniker commented 10 months ago

I moved common code into functions to improve code reusability and readability. I added clear function and variable names to make the code self-documenting. The validateChainConfigurator function validates the chain configurator, and logChainConfiguratorInfo logs its information. The testEquivalent function encapsulates the testing logic and makes it easy to test different chain configurators. I improved the structure of the TestEquivalent_Features function to keep the code clean and organized. These changes make the code more maintainable and easier to understand.

meowsbits commented 10 months ago

@quantumtechniker Thanks for the PR!

The following test is failing, please fix before we can proceed with review.

go test ./integration
# github.com/ethereum/go-ethereum/integration
integration/configurator_2test.go:20:2: "encoding/json" imported and not used
integration/configurator_2test.go:44:37: undefined: nicelog
integration/configurator_2test.go:45:38: undefined: nicelog
FAIL
meowsbits commented 9 months ago

No response here, so we won't merge an unsupported PR. Please feel free to reopen if you find time to address the above concerns.