search

etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.
https://etclabscore.github.io/core-geth
GNU Lesser General Public License v3.0
267 stars 147 forks source link

Update 2merkle.go #574

Closed quantumtechniker closed 9 months ago

quantumtechniker commented 10 months ago

The code now provides more detailed error messages for common issues, making it easier to diagnose problems during verification. It uses Goroutines and a WaitGroup to parallelize the verification process, which can significantly improve performance when verifying large Merkle trees. It checks for index bounds and handles them gracefully, preventing out-of-bounds errors. The code is structured to provide cleaner error handling and better concurrent processing.

meowsbits commented 10 months ago

@quantumtechniker Thanks for the PR!

The code now provides more detailed error messages for common issues, making it easier to diagnose problems during verification.

Can you give an example of these common errors?

It uses Goroutines and a WaitGroup to parallelize the verification process, which can significantly improve performance when verifying large Merkle trees.

Can you show benchmarks or other reference for this claim?

meowsbits commented 9 months ago

No response here, so we won't merge an unsupported PR. Please feel free to reopen if you find time to address the above concerns.