search

etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.
https://etclabscore.github.io/core-geth
GNU Lesser General Public License v3.0
275 stars 150 forks source link

Merge/foundation release/1.13.4 to 1.13.1 #575

Closed ziogaschr closed 7 months ago

meowsbits commented 11 months ago

Not sure why the linter is failing -- https://github.com/etclabscore/core-geth/actions/runs/6668444378/job/18124021689?pr=575. Does not fail locally. 

git rev-parse HEAD ; make clean && make lint ; echo $?
dd25262de746f1b1673b877bdc69055968b3381e
rm -rf ./build/_workspace/hera ./build/_workspace/evmone
go clean -cache
rm -fr build/_workspace/pkg/ ./build/bin/*
go run build/ci.go lint
gotool.go:147: Found version "1.51.1"
build/cache/golangci-lint-1.51.1-linux-amd64.tar.gz is up-to-date
>>> build/cache/golangci-lint-1.51.1-linux-amd64/golangci-lint run --timeout 5m0s --config .golangci.yml ./...
You have achieved perfection.
0
ziogaschr commented 8 months ago

I finished the review of the code. I will check back the comments and run a sync before accepting the PR.

ziogaschr commented 8 months ago

https://github.com/etclabscore/core-geth/pull/575#issuecomment-1783092932

@meowsbits you have to manually delete build/cache/golangci-lint-1.51.1-linux-amd64.tar.gz

edit: there is no reason for this to fail on GH actions

meowsbits commented 7 months ago

Review done, closing in favor of https://github.com/etclabscore/core-geth/pull/593.