Closed meowsbits closed 10 months ago
Good thought, but on looking at it, they don't have this issue. Their diff on this commit looks like this:
diff --git a/node/node.go b/node/node.go
index 41c9971fe8..e58e0a61bb 100644
--- a/node/node.go
+++ b/node/node.go
@@ -272,8 +272,10 @@ func (n *Node) openEndpoints() error {
// start RPC endpoints
err := n.startRPC()
if err != nil {
+ log.Error("Failed to open RPC endpoints", "error", err)
n.stopRPC()
n.server.Stop()
+ return err
}
return err
}
core-geth mishandled this because the error was overwritten by the OpenRPC error, where ethereum/go-ethereum, without an OpenRPC service to start, returns the error as-is.
Great @meowsbits. We had this in our tasks for a long time. :) Thanks
Errors returned from this function were getting ignored, resulting in silent-but-deadly startup errors, especially around authrpc, which is a relatively new addition, and the port collision of which causes a lot of people a lot of headaches.
Date: 2023-11-01 07:51:52-06:00
See screenshot from a bug report on Discord --
Now, it'll behave like this: