etclabscore / core-geth

A highly configurable Go implementation of the Ethereum protocol.
https://etclabscore.github.io/core-geth
GNU Lesser General Public License v3.0
263 stars 144 forks source link

Fix UPnP unwanted termination #611

Closed ziogaschr closed 5 months ago

ziogaschr commented 5 months ago

This pull request fixes the issue where the portMappingLoop function was prematurely terminated, causing the defer function to be called and trigger "Deleting port mapping" 2 minutes after the initial launch. The fix involves changing the return statement to a continue statement in order to continue the loop.

Fixes #609.

Background: this has been introduced with https://github.com/ethereum/go-ethereum/pull/26359. If this PR solves the issue we will make a PR at ethereum/go-ethereum as well.