search

etclabscore / jade-service-runner

👟 Jade Service Runner
https://jade.builders/
Apache License 2.0
16 stars 8 forks source link

Error handling in jade-service-runner `serviceManager` #200

Open bakon11 opened 5 years ago

bakon11 commented 5 years ago

Describe the bug When making request to jade-service-runner to start new service. Upon an error returns { "id": 1, "jsonrpc": "2.0", "result": { "error": { "code": 6969, "message": "unknown error" } } }

To Reproduce Steps to reproduce the behavior: Make call to start service that isn't installed { "jsonrpc": "2.0", "method": "startService", "params": ["multi-geth", "1.9.2", "kotti"], "id": 1 }

zcstarr commented 5 years ago

Just dropping this comment here. The error message should use the new standard JSONRPCError framing from serverjs and include better messaging.