search

etclabscore / jade-signer-rpc

🔏Jade Signer JSON-RPC lets you manage keys and sign transactions and messages offline for any EVM-based blockchain.
Apache License 2.0
6 stars 3 forks source link

fix: convert custom errors to use failure #67

Closed zcstarr closed 4 years ago

zcstarr commented 4 years ago

@mersinvald wasn't sure if this was the conversion thought you had in mind. I haven't done the whole thing or killed comments. But is this the intent ?

mersinvald commented 4 years ago

@zcstarr LGTM, I will merge it as soon as I fix the releases

zcstarr commented 4 years ago

@zcstarr LGTM, I will merge it as soon as I fix the releases

I think this still needs a little more work, it's got commented out code and stuff. I'll ping you with a PTAL when I remove that stuff and add this change to the rest of the code base for error handling.

zcstarr commented 4 years ago

@mersinvald PTAL . I did the rest of the refactor and added a comment on some lines I removed mind weighing in one more time?

mersinvald commented 4 years ago

@zcstarr can you please rebase the branch onto the current master, so CI would fire for this PR?

zcstarr commented 4 years ago

@mersinvald it is rebased 🤔 . I can always force push again ....

mersinvald commented 4 years ago

@zcstarr it's rebased onto your fork master, not the current master of this repo

zcstarr commented 4 years ago

I did some linting as well

zcstarr commented 4 years ago

closing for CI reasons