search

etclabscore / multi-geth-fork

GNU Lesser General Public License v3.0
3 stars 8 forks source link

params: rename client to CoreGeth #147

Open soc1c opened 4 years ago

soc1c commented 4 years ago

ref #146

because people asked why we need to rename:

  1. we don't have access to the Multi-Geth repository and brand
  2. we cannot have our own competing release track under the same name
  3. with Multi-Geth barely being maintained, we need to make our repository stand out as independent project
  4. changing client identifiers helps with analyzing the health of the network
soc1c commented 4 years ago

Good catch. Can you check again?

Edit: I'm unsure core is actually used over the network now. Wondering how to test that.

meowsbits commented 4 years ago

You mean just the peer name like below?

> admin.addPeer("enode://2d95d69f8d212a3eef132dd615b3b7bf41dc01dd4703185c9a12a5814c57c35a9ff406b9d353f005333ea3284c63732534e2c55e4619cfb5c4f872bb453e80e6@127.0.0.1:30303?discport=0");
true
> admin.peers
[{
    caps: ["eth/63", "eth/64"],
    enode: "enode://2d95d69f8d212a3eef132dd615b3b7bf41dc01dd4703185c9a12a5814c57c35a9ff406b9d353f005333ea3284c63732534e2c55e4619cfb5c4f872bb453e80e6@127.0.0.1:30303",
    id: "0de87a6f64aebc03e7309741fd6a88f1c77ff93c1ce6a5ecf06bda6bf8eeffa7",
    name: "CoreGeth/v1.9.10-unstable-21f13900-20200218/linux-amd64/go1.13.5",
    network: {
      inbound: false,
      localAddress: "127.0.0.1:42344",
      remoteAddress: "127.0.0.1:30303",
      static: true,
      trusted: false
    },
    protocols: {
      eth: {
        difficulty: 17179869184,
        head: "0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3",
        version: 64
      }
    }
}]
soc1c commented 4 years ago

Yeah, looks good.

meowsbits commented 4 years ago

Looks like we need to clean up Appveyor, out-of-storage-space error is causing the builds to fail.

2020-02-18-171828_1017x382_screenshot https://ci.appveyor.com/project/chunfuyang/multi-geth-5su26/builds/30892853

meowsbits commented 4 years ago

Ha, although the Appveyor retention policy issue may just go away when we swap namespaces.

Also one does not just "clean up appveyor" apparently; instead one requests extended storage limits. Or waits 6 months for them to be auto-deleted.