etclabscore / multi-geth-fork

GNU Lesser General Public License v3.0
3 stars 8 forks source link

Chainspecs and cross-client,cross-chain tests #64

Closed meowsbits closed 5 years ago

meowsbits commented 5 years ago

:warning: Based on #65 to greatly simplify diff. Please review that first.

:rabbit: Inclusively supersedes #61.


TL;DR

> make test-multigeth-chainspecs
> make tests-generate
> make test-multigeth-features

This is, to a large extent, a revisitation and rebuild of https://github.com/multi-geth/multi-geth/pull/103, which was built adhoc in preparation of the ETC Atlantis fork. With ETC Agharta around the corner, the need for cross-client compatible non-Foundation chain tests has risen again.


Full Notes

:bookmark: Please see https://github.com/etclabscore/multi-geth/wiki/PR:-Chainspecs-and-cross-chain,cross-chain-test-generation.

meowsbits commented 5 years ago

Going to merge.

Since this is so big and architecturally significant, and touches several chain configs and consensus implementations, I think we should put the resulting master version thru sanity and manual "regression" tests to make sure we don't see any obvious unexpected or missing behavior.