etclabscore / multi-geth-fork

GNU Lesser General Public License v3.0
3 stars 8 forks source link

un"hardcode" setting chain configuration #67

Open meowsbits opened 5 years ago

meowsbits commented 5 years ago

this needs improving:

https://github.com/etclabscore/multi-geth/blob/master/cmd/utils/flags.go#L1567-L1623

having "hardcoded" switches for default chain configs everywhere is too complex and too redundant and leaves too many opportunities for errors and inconsistencies:

much of this is because of crufty, brittle code (inheriting code where these cases have been carelessly hardcoded with approaching infinite opinionation).

I'm not sure the best pattern for approach yet. Big global? Moar interfaces? Mmmm..

Rel #63

meowsbits commented 4 years ago

Changes should (eventually):