`zune-bmp` decode doesn't support icc feature

etemesi254 / zune-image

A fast and memory efficient image library in Rust

Other

332 stars 30 forks source link

`zune-bmp` decode doesn't support icc feature #195

Closed Mikachu2333 closed 6 months ago

Mikachu2333 commented 6 months ago

When input a pic which has an icc profile and decode with zune-bmp, the color will be changed incorrectly as the following link shows.

https://github.com/SalOne22/rimage/pull/208#pullrequestreview-2039320505

etemesi254 commented 6 months ago

I am yet to find sources on how to read ICC profiles from bmp, the microsoft docs is a bit vague on that.

But working on it

Mikachu2333 commented 6 months ago

thanks for answer!

etemesi254 commented 6 months ago

v0.5.0-rc4 should have a icc. It may still not be correct because I don't yet have an ICC reader hence couldn't check if it's fully working, so if it works for your case, please confirm here