etendosoftware / etendo_core

Etendo Classic source code
9 stars 10 forks source link

Issue #306: fix custom accounting for internal consumption #401

Closed Amar-Etendo closed 3 months ago

Amar-Etendo commented 3 months ago

Issue #306: added the fix to allow the custom accounting while posting internal consumption document EPL-1238

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

facumoyanosmf commented 3 months ago

Issue #306>: added the fix to allow the custom accounting while posting internal consumption document EPL-1238

@Amar-Etendo The commit name should be Issue #306: ..., not Issue #306>: .... On the other hand, the characters of each message must not exceed 70 characters. Methodology for repository management

RubenEtendo commented 3 months ago

@Amar-Etendo Check the sonar comment, you have a code smell in this Pull Request

Other than that, the code looks fine, good job!

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

RomanMagnoli commented 3 months ago

As the sonar Analysis said, the method has high cognitive complexity. This should be fixed. Selección_951

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

RubenEtendo commented 3 months ago

Issue #306>: added the fix to allow the custom accounting while posting internal consumption document EPL-1238

@Amar-Etendo The commit name should be Issue #306: ..., not Issue #306>: .... On the other hand, the characters of each message must not exceed 70 characters. Methodology for repository management

@Amar-Etendo remember what @facumoyanosmf told you about the commit message. The new commit also has the '>' in it

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

3 Issues

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

sonarscanetendo[bot] commented 3 months ago

Failed

Analysis Details

1 Issue

Coverage and Duplications

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

etendobot commented 3 months ago

One or more commit messages do not meet the required standards. Please correct them.

etendobot commented 3 months ago

One or more commit messages do not meet the required standards. Please correct them.

etendobot commented 3 months ago

One or more commit messages do not meet the required standards. Please correct them.