search

eteran / c-vector

A dynamic array implementation in C similar to the one found in standard C++
MIT License
737 stars 109 forks source link

Make grow strategy per vector instead of global #60

Closed yiselieren closed 5 months ago

yiselieren commented 1 year ago
  1. Make grow strategy local per vector instead of using it globally
  2. Add cast in cvector_reserve allowing to use signed integers as a parameter of the macro
eteran commented 8 months ago

Sorry for the delay on this. I'm somewhat torn on this PR. I can definitely see the utility of it, sometimes you want your vector to grow incrementally, sometimes you want it to double, maybe you even what a 3rd option.

But...

On the other hand, usually I've found that one or the other is just generally right for the current system. Heck c++ doesn't even give you an option, it's just left up to the implementation to decide. And honestly, there's been a bit of feature bloat already with the destructor stuff. So I'm not sure I want to add yet another feature for a niche usage.

So, I'll think on it.

All of that being said, if you still are interested in it being merged, please ensure that it passes the clang-tidy check above as I'd prefer to merge PRs as is and you'll also need to add the new parameter to test.c so it passes the build again.

Sorry it took so long to respond to this, and that I allowed your PR to get stale while a few others merged and conflicted.

eteran commented 5 months ago

Unfortunately this PR has fallen too far behind master to really bring up to date. if the OP wants to re-introduce it, please open a new PR based on the latest code.