eteran / edb-debugger

edb is a cross-platform AArch32/x86/x86-64 debugger.
GNU General Public License v2.0
2.68k stars 323 forks source link

Add option to disable jump draw #731

Closed shahrilnet closed 4 years ago

shahrilnet commented 4 years ago

Changes made:

  1. Added option to disable jump draw

image

  1. Fixed possible crashing when accessing showaddresses function

  2. Dock registers badge at the left side of line1

image

Any comments is really appreciated. :)

10110111 commented 4 years ago

When I set Show jump arrows and unset Show when registers are pointing to a visible address, the space allocated appears to be large enough for both, although only one thing is enabled.

shahrilnet commented 4 years ago

@10110111, that is intended behavior, as register badge is drawn inside jump arrow area (on the left side of the first line)

Toggling Show when registers are pointing to a visible address while Show jump arrows is set will not change the space/area allocated.

10110111 commented 4 years ago

It's not drawn when it's disabled, is it?

shahrilnet commented 4 years ago

Peek 2019-11-02 03-48

Register badge is drawn inside jump arrow area, so there is no effect on area allocated if either the badge is drawn or not.

Jump arrow area is always going to be initiated as this size (https://github.com/eteran/edb-debugger/pull/731/files#diff-4af38e37cb69a85d76c168f3230a7adeL1650)

Unless I misunderstood what you're saying just now 😅

10110111 commented 4 years ago

Ah, so you made it more economical... But don't you think it's not very nice when the arrows go over the badges, like in the following screenshot? Screenshot - 011119 - 23:09:30

shahrilnet commented 4 years ago

@10110111 that is a good catch (doesn't appear in my test 😅)

thank you! will fix it soon

shahrilnet commented 4 years ago

@10110111 latest commits fixed issues that you pointed out

10110111 commented 4 years ago

In other respects, this looks fine to me now.

shahrilnet commented 4 years ago

Pushed fixes as mentioned by @10110111

eteran commented 4 years ago

Looks good to me! Merging!

@10110111 Thanks for the code review, @shahril96 thanks for this awesome contribution!