Closed shahrilnet closed 4 years ago
When I set Show jump arrows and unset Show when registers are pointing to a visible address, the space allocated appears to be large enough for both, although only one thing is enabled.
@10110111, that is intended behavior, as register badge is drawn inside jump arrow area (on the left side of the first line)
Toggling Show when registers are pointing to a visible address while Show jump arrows is set will not change the space/area allocated.
It's not drawn when it's disabled, is it?
Register badge is drawn inside jump arrow area, so there is no effect on area allocated if either the badge is drawn or not.
Jump arrow area is always going to be initiated as this size (https://github.com/eteran/edb-debugger/pull/731/files#diff-4af38e37cb69a85d76c168f3230a7adeL1650)
Unless I misunderstood what you're saying just now 😅
Ah, so you made it more economical... But don't you think it's not very nice when the arrows go over the badges, like in the following screenshot?
@10110111 that is a good catch (doesn't appear in my test 😅)
thank you! will fix it soon
@10110111 latest commits fixed issues that you pointed out
In other respects, this looks fine to me now.
Pushed fixes as mentioned by @10110111
Looks good to me! Merging!
@10110111 Thanks for the code review, @shahril96 thanks for this awesome contribution!
Changes made:
Fixed possible crashing when accessing showaddresses function
Dock registers badge at the left side of line1
Any comments is really appreciated. :)