eteran
commented
2 years ago Thank you for the PR!
I generally agree with @10110111's comments, but do love the idea of making things more memory efficient where they can be.
If you can address the concerns he mentioned, I think we'll likely be happy to merge in your contribution 👍
Instead of trying to read an entire debuggee process region at once, read up to 4096 pages at a time. This should reduce memory issues when running against processes that allocate huge amounts of memory such as modern games.
In addition, slightly optimize the performance if byte alignment is on.