search

eteran / edb-debugger

edb is a cross-platform AArch32/x86/x86-64 debugger.
GNU General Public License v2.0
2.66k stars 321 forks source link

Fix build with Capstone 5 #824

Closed thesamesam closed 1 year ago

thesamesam commented 1 year ago

Fix build with Capstone 5

Capstone 5 drops X86_INS_VCVTPD2DQX and X86_INS_VCVTPD2PSX from x86.h (happened in https://github.com/capstone-engine/capstone/commit/dd91f03fef5102492352756e2adb5972dd79a70f but no real explanation).

Given:

  1. these instructions had no wiring up;
  2. other Capstone consumers have done the same let's drop them entirely as we have no idea what they are. They don't appear in any Intel documentation and there's very little reference to them online at all.

Bug: https://bugs.gentoo.org/843755 Closes: https://github.com/eteran/edb-debugger/issues/823 Signed-off-by: Sam James sam@gentoo.org

10110111 commented 1 year ago

Given that these instruction names already puzzled me when I first added them to this switch (Intel has no docs for them, nor does a web search reveal any), I wonder whether they have actually ever been emitted by Capstone. Maybe these lines should be simply removed?

thesamesam commented 1 year ago

That sounds like a good idea. I was being conservative just in case the FIXME comment was obsolete, but I don't see any benefit to keeping these here at all. Let me update this to drop them.

eteran commented 1 year ago

LGTM. Thanks for the patch!

thesamesam commented 1 year ago

Thanks!