eteran / edb-debugger

edb is a cross-platform AArch32/x86/x86-64 debugger.
GNU General Public License v2.0
2.66k stars 321 forks source link

FreeBSD: Debugger.h:25:10: fatal error: 'OSTypes.h' file not found #830

Closed Martinfx closed 1 year ago

Martinfx commented 1 year ago

Hi, i have issue with compilation on FreeBSD 13.1 x64. i can make port to FreeBSD.

FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303) Target: x86_64-unknown-freebsd13.1 Thread model: posix InstalledDir: /usr/bin

edb-debugger/src/edb_autogen/EWIEGA46WW/../../Debugger.h:25:10: fatal error: 'OSTypes.h' file not found
#include "OSTypes.h"
     ^~~~~~~~~~~
Martinfx commented 1 year ago

fix is

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f561cf7d..56108fcc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -63,6 +63,8 @@ include_directories("include")
 if(TARGET_PLATFORM_LINUX)
        include_directories("include/os/unix")
        include_directories("include/os/unix/linux")
+elseif(TARGET_PLATFORM_FREEBSD)
+       include_directories("include/os/unix")
 elseif(TARGET_PLATFORM_WINDOWS)
        include_directories("include/os/win32")
 endif()
eteran commented 1 year ago

seems reasonable, if you put in a PR for this one line change it'll be a good baseline to start working on making things build on freeBSD again :-)

Martinfx commented 1 year ago

good idea :-)

eteran commented 1 year ago

Addressed by PR