Closed bztd closed 5 months ago
The new version looks rather untidy. Particularly, the spacing between the blue curves is not symmetric with respect to the horizontal midline.
@10110111 I'm not good at crafts, even so I tried to make it look as similar as possible. See if I can improve.
Nor is my intention for it to be "new" only to provide the 64 and 128 version for https://github.com/eteran/edb-debugger/issues/808
@bztd No need to close the issue :-). While these are imperfect, they are probably OK enough for the flatpak stuff.
All of that being said, I have been thinking lately that edb could use a refresh on it's icon too. I'm no artist, but we'll see what we can do. I appreciate your effort!
@10110111 So I think the goal of creating a flatpak is generally worth the untidy logo's (for now). I've been considering creating a new logo sometime soon, so I generally consider these are temporary anyway.
(And now we're in the age of AI, maybe I can prompt engineer a nice high-res logo using generative AI tools, who knows).
Anyway, let me know if you have any issues with merging this in for the sake of making progress on #808 and also if you'd like to take part in choosing a new logo at some point
I'm OK with this if you think this is good enough. I'd just note that there's nothing more permanent than a temporary solution.
I was thinking about adding an svg, for flatpak it is enough. I've been looking at some combinations of mathematical functions to find symmetry but I haven't had much success.
I'd just note that there's nothing more permanent than a temporary solution.
Very true! I do hope to not fall victim to that habit, but I do recognize that it's an easy trap to fall into.
I'm hopeful that we can develop a fresher logo, ideally an SVG based one sometime soon.
@bztd do please keep looking into it! I love the idea of an svg based logo since it's just generally better. Especially given that the logo is comprised of simple shapes.
@10110111 well, I took some inspiration and tried to make an SVG that looks like the classic edb logo.
I'm no artist and certainly am not particularly talented with SVG creation, but fortunately we're dealing with some simple shapes.
Any feedback?
It seems fine to me. maybe the color of the letters is confused with a dark background
Yeah I was thinking I could lighten up the letters a bit too
version 2. Now has a slightly lighter coloring on text, and a slight drop shadow so it still reads on light backgrounds too.
(oddly, at least in chrome, when I click it from this PR, it doesn't render right. but when I directly open it in any browser, it looks perfect, including when chrome renders it in this PR directly).
I have had problems with the visualization with inkscape, only the text is displayed.
What software do you use, I'm curious to see what type of composition you made?
I just googled and picked the first thing, I ended up using a web app called "BoxySVG", not bad for an in browser application:
When I click the image to open it in a new tab, the curves don't display, only text is visible, and it's black (the second version also has a shadow of the text). Tried both in Chromium and Firefox. Maybe the SVG is somehow broken?
Regarding the look itself, I think it would be nicer if the tips of the curves lied on a single straight line. Currently they don't, which makes me feel it as imperfect:
But this is just an idea. I can imagine that an attempt to "fix" this may result in an uglier look.
Also, I'd make the spacing between the curves more equal in the middle. This will also make the tips align better without even stretching the innermost curve.
Indeed, something strange is going on with the transforms here. Here's how it looks if I open in Inkscape:
Strange indeed, I can try to fix it in ink scape.
Good point about the spacing, I'll see if I can fix it. I kinda just eyeballed it.
That being said if you are qualified to fix the SVG, do feel free try 😜.
As I said, I'm no expert in SVGs
@10110111 thanks for the feedback, you attention to detail always helps. Here's a v3 of it. I've done it with inkscape so hopefully it will render correctly everywhere.
Beside that, I tried to make the spacing more even and got the tips to be closer to a straight line, but honestly, it looked off to me when I tried to make them all in a perfect line (it negatively effected the spacing between curves).
Anyway, as always, let me know what you think.
Sorry for spamming (probably the last for a bit) but here's a v3, which has a better implementation of the shadow for the text:
better implementation of the shadow for the text
I find it too low-contrast. The previous version is better IMO.
Here's my attempt at aligning the crescents. It's still not perfect, and the use of boxy-svg bx
namespace in the definition of the path makes me wonder where to find the docs on what the sequence of numbers represents here. But at least flipping the image vertically leads to a much smaller change than in your version.
I like your version as well. One thing, I literally can't download it. When I click on it, I get a message saying it's private, and when I try to use something like save image as, I get a message saying the image was unavailable.
So strange, because I can literally SEE it in my browser, I just can't get chome to download it.
OK, it was just chrome being dumb, firefox could download it just fine
OK, so I think this looks great, I'll work on a PR to make THIS last tweaked version you made the logo source!
(and we can always tune it later too if there's nits to pick).
Thanks as always @10110111 , and thank you @bztd too for lighting a fire under my butt a fire for this stuff. I've been so caught up with life the past couple of years that things like personal projects have gotten a lot less attention. Not a bad thing, but edb could use a little more love (and I have a bunch of ideas for improvements) ;-)
OK, @bztd I'm closing this PR as complete since we worked it out. Can you please tie up any loose ends with the flatpak and maybe describe how to install it via that to make sure it works?
@eteran I'll see if it compiles. to the point that some errors only appear when the package is compiled on the server, because if I'm not wrong locally, the appdata.xml check is not done
Logo