search

eteran / edb-debugger

edb is a cross-platform AArch32/x86/x86-64 debugger.
GNU General Public License v2.0
2.68k stars 323 forks source link

Run lupdate on plugins too #869

Closed 10110111 closed 1 month ago

10110111 commented 1 month ago

This makes plugins translatable. The full command is:

lupdate src plugins -ts ./src/res/translations/edb_zh_CN.ts
eteran commented 1 month ago

This definitely will work correctly for first party plugins. One thing we will probably need to consider is how 3rd party plugins interact with translations (if at all). Do we eventually allow translation files to be embedded in the plugin themselves so they can be loaded as well?

10110111 commented 1 month ago

Do we eventually allow translation files to be embedded in the plugin themselves so they can be loaded as well?

One way may be to query all the plugins for their own QTranslators and install them after (or before?) the app's ones. Not sure how this would work for conflicting strings translated differently.

eteran commented 1 month ago

Yeah, something like this a good idea. We'll have to experiment with it.

eteran commented 1 month ago

@10110111 are you thinking that this one should be merged too?

10110111 commented 1 month ago

I think it's a good start to get something at least all the stock GUI translatable. If you come up with a way to make external plugins translatable, this can be done in subsequent commits, with the strings being already present (assuming you get your translators to fill them in), just waiting for possible splitting.

eteran commented 1 month ago

cool, i'll merge this in then :-)

Thanks as always!