search

eteran / nedit-ng

a Qt5 port of the NEdit using modern C++14
GNU General Public License v2.0
95 stars 26 forks source link

text is statistic line off center vertically on linux #295

Closed tksoh closed 3 years ago

tksoh commented 3 years ago

Running commit 9e9acf13b028d86a5a9951b3534a5a71bcad6d7c

This is a really minor cosmetic issue. Somehow on Linux the text are off center, leaving about twice a empty space below the text line compare to the space above the line. They look okay on Windows 10.

2021-01-26 13_45_12-toshiba (tksoh's X desktop (tksoh-Satellite-L645_1)) - VNC Viewer

pwhitbread commented 3 years ago

Can I also add that the lack of padding on the left and right margins is a bit ungainly? i.e. in the above screenshot, where the / touches the left edge and the 0 touches the right edge.

eteran commented 3 years ago

The left/right padding should be pretty easy to tweak :-)

eteran commented 3 years ago

Should have a fix for this soon, sorry for the long delay.

tksoh commented 3 years ago

Just tried the latest commit. Unfortunately the vertical position is still off center.

eteran commented 3 years ago

@tksoh right, i haven't had a chance to do the minor fix for this (work has been super busy!), but I'll try to get one in soon!

tksoh commented 3 years ago

Oh, I misread your reply. Take your time.

eteran commented 3 years ago

Sorry that things took so long!! Just been SO busy lately. Just did a commit in master that does two things:

  1. adds a little padding to the left and right of the status bar.
  2. tightens up the vertical borders around the status widget. Interestingly, the text is actually vertically aligned in the label widget... but the label itself is in a layout that has some padding around it. So I've tightened that up to help make things (hopefully) appear more vertically centered. Unfortunately, this may be a bit theme-sensitive. For me, things looked fairly vertically centered, even before this change in KDE's default widget theme.

Please let me know if this helps address the problem!

eteran commented 3 years ago

@tksoh out of curiosity, does the latest in master help the look on your end?

tksoh commented 3 years ago

It looks centered now (the nedit-ng window at the top). Also, the font size is a little larger. Not sure it's been changed in the code somehow, but I personally like it better than the old font size.

2021-06-03 13_19_18-toshiba (tksoh's X desktop (tksoh-Satellite-L645_1)) - VNC Viewer

eteran commented 3 years ago

Interesting about the font, it certainly wasn't intentionally adjusted, but if it looks better... I'll take it!