eternagame / HTML-Chat

HTML5 implementation of chat to replace the legacy Flash-based implementation
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Bad username formatting with special characters #39

Closed luxaritas closed 6 years ago

luxaritas commented 7 years ago

For example, logging in with a space at the end of your username winds up adding %20 to your username, even though it is accepted for a login. Really, the "correct" username should be gotten from the API.

Edit: Per https://github.com/EteRNAgame/HTML-Chat/issues/39#issuecomment-293789894, this is the full extent of how this issue needs to be solved

luxaritas commented 7 years ago

Kudos to Astromon for finding this one.

luxaritas commented 7 years ago

Fixed in #42

luxaritas commented 7 years ago

Oops, this was not fixed - wrong issue!

luxaritas commented 7 years ago

Just realized that this doesn't just apply to the test page. There are three things that need fixing:

(Edit: Added the task list to the first post in the issue so that it can be tracked)