search

eternagame / HTML-Chat

HTML5 implementation of chat to replace the legacy Flash-based implementation
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

anonymous login to #test #42

Closed guyguy2001 closed 7 years ago

guyguy2001 commented 7 years ago

fixed. it can have multiple guests with the same username but it isn't really a problem, will just be a random laugh (and it is 1 in 1000 chance)

luxaritas commented 7 years ago

Looks good - meta tags should not be closed, and the spacing shouldn't have caused any issues. function() without the space is still ok, as it is more like function f() (I'm not making this up, other projects do this :P), but I can always go back and change that later. I also think I'll want to compress the object literal on line 43, as it's a small amount of code and keeps things compact, but I'll have to think about it.

Eventually, we'll develop or adopt an actual style guide and use lining, but at this point, it's more about getting close. Preferred style is something that can continued to be discussed.

I'm going to change this so that it merges into dev instead of master, particularly as I have some related updates & testing I'll want to do before release.