search

eternagame / HTML-Chat

HTML5 implementation of chat to replace the legacy Flash-based implementation
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Handling disconnections #48

Closed guyguy2001 closed 7 years ago

guyguy2001 commented 7 years ago

Disconnections are now automatically handled.

This PR is more to show it to you, since im not sure if I can when it is only on my repo. Also, it fails to connect when the site succeeds, but it could be my internet fault. Also, is it okay to look that way when the chat is in the size of the site's chat?

EDIT: Fixes #3

luxaritas commented 7 years ago

Looks like we're finally synced up. Code looks good, I'll try to do a test run with your branch of the code to make sure everything's working properly, then I'll merge it in. Hopefully that will happen tomorrow.

Thanks for the help, this is one of the last blocking points to getting this pushed out on the main site.

guyguy2001 commented 7 years ago

PS I am not sure how safe it is actually... As long as the connection takes 5 or more seconds, 5 out of every 30 seconds will be blocked for each clients, and they sync it, so with 6 clients as slow as that, the chat will certainly be down 100% of the time.

guyguy2001 commented 7 years ago

I take what I said back. I need to double check it later, but the server probably handles all of the messages between connection attempts, which would really be good enough. EDIT: pretty much confirmed. The only problem that could happen is logins which takes too much time, although more than 20 seconds is rare or nonexistant

luxaritas commented 7 years ago

Everything looks good - thanks for your work on this!