search

eternagame / HTML-Chat

HTML5 implementation of chat to replace the legacy Flash-based implementation
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

mcustomscrollbar breaks chat inside cross-domain iframe #52

Closed luxaritas closed 7 years ago

luxaritas commented 7 years ago

We planned for www.eternagame.org to (temporarily) load the chat from irc.eternagame.org as an iframe. A bug in the custom scrollbar causes an error when this happens.

There is a patch for this at https://github.com/malihu/malihu-custom-scrollbar-plugin/pull/451, but apparently, the repo is not maintained. Should we fork it and merge in the fix (@omei, I think this would be up to you)? Or should we use a different library? This will be replaced once the rewrite happens anyhow (assuming we use Vue, we should ditch jQuery as a dependency).

luxaritas commented 7 years ago

Two examples: https://github.com/noraesae/perfect-scrollbar https://github.com/idiotWu/smooth-scrollbar

guyguy2001 commented 7 years ago

May I patch any of them in? If so, are there any preferences to which?

luxaritas commented 7 years ago

@guyguy2001 Preferences to which what?

guyguy2001 commented 7 years ago

Which library to use

luxaritas commented 7 years ago

Frankly, what I care about is that it works and it looks ok. :)

luxaritas commented 7 years ago

Resolved in 3201bac