search

eternagame / eterna-mobile

Eterna mobile app
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Open screenshots in app #28

Open tkaragianes opened 2 years ago

tkaragianes commented 2 years ago

"Clicking an Eterna screenshot in chat takes me to an outside browser (in my case, Chrome) - would be cool if I could view it from within the app"

I have a feeling that this is related to Cordova. Not sure if we want to address it now or with the refactor.

tkaragianes commented 2 years ago

This behavior is the same as currently implemented in the site (e.g., screenshots open in a new tab, not in app). There are ways to solve this now (cordova inappbrowser plugin), but my recommendation is to push this improvement as part of the refactor so we can implement it correctly in both the mobile app and website.

luxaritas commented 2 years ago

The Vue chat rewrite actually embeds image links (or at least screenshots), so that's probably the real resolution of this specific issue - though we may still want chat links in general to open with an in-app browser?