search

eternagame / eterna-mobile

Eterna mobile app
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Fix "Load More" button styling #36

Closed tkaragianes closed 2 years ago

tkaragianes commented 2 years ago

Addresses #29. Fixes the :focus state that results in a visually still-active button.

luxaritas commented 2 years ago

I'm a bit hesitant about this, as focus indication is still an accessibility issue on mobile. Can we maybe tweak the styling to still have a focus indicator but make it feel less like an active state (maybe by having additional styling when the button is pressed)?

tkaragianes commented 2 years ago

That's actually what this fix does. The standard browser focus outline still shows up, but the :focus state no longer looks like the :active state. Bootstrap adds a border and changes the background-color in both :focus and :active states, so they look very similar. I'm removing Bootstrap's border and background-color changes, but retaining the browser's default focus outline.

luxaritas commented 2 years ago

Ah! Definitely reasonable.