search

eternagame / eternagame.org

Website for the Eterna citizen science game
https://eternagame.org
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Software license request & download flow #181

Closed akrolsmir closed 4 years ago

akrolsmir commented 4 years ago

NOTE: This does not yet pull from the /get/?type=software_packages endpoint, but rather from the json in SoftwareExplore.vue

What the license agreement looks like:

What the download page looks like:

akrolsmir commented 4 years ago

@luxaritas The download process in VersionCard is a bit convoluted, owing to the way the download endpoint works. Namely, we don't have a direct file link (if we did, we could replace the whole thing with <a download href="link>)

Instead, we use axios to download the bytes first, then locally build an invisible download link to click. Seeing as we download a server copy of the file anyways, I'd suggest sending that file link back to the client, instead of streaming the 100MB+ download. This would have the benefit of e.g. showing the user their download progress using browser conventions like in Chrome, while simplifying our implementation. Thoughts?

(Ofc we can do this in a follow-up PR, to unblock EternaBench)

luxaritas commented 4 years ago

You should be able to just hyperlink it as-is - errors just won't be presented very well. I'll work on that