Pagination, filters, result count

eternagame / eternagame.org

Website for the Eterna citizen science game

https://eternagame.org

BSD 3-Clause "New" or "Revised" License

19 stars 17 forks source link

Pagination, filters, result count #215

Closed AlexHalb closed 1 year ago

AlexHalb commented 4 years ago

Adds an option to use pages or infinite scroll on puzzles. Also adds a switch filter and displays how many results there are for a query.

Resolves #38
Resolves #120

luxaritas commented 4 years ago

Looks great, but a couple things that need to be resolved:

Switching between pagination/scroll should not require reloading the window
This breaks other gallery pages, eg labs
This should probably be implemented in the existing pagination component - provide a prop to it that will either show the pagination or use infinite scroll. Then we can enable it for labs, etc

AlexHalb commented 4 years ago

Those should all be resolved now.

luxaritas commented 4 years ago

More bugs :D

Using the paginated view, I'm semi-regularly getting an "Avoided redundant navigation to current location" error
When changing to scroll, I get two spinning loaders, and the previously existing content disappears
When changing the page, the pagination widget shifts to the left of the screen instead of staying centered while it's loading
The pagination probably shouldn't be green - way too stark imo. maybe look at some of the blue options

luxaritas commented 4 years ago

I think tags were reenabled on too many things - should just be on the puzzle list. I think UID search also needs to get added to the puzzle list as well?