search

eternagame / eternagame.org

Website for the Eterna citizen science game
https://eternagame.org
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Fixed Group Notifications (Broadcasts and Comments) #236

Closed OsamahAnsari closed 3 years ago

OsamahAnsari commented 3 years ago

Fixes a handful of issues related to group notifications.

Resolves: #110

  1. Group Broadcasts no longer contain a link
    • The nid referenced by the link points to the notification id rather than the group id
    • Wrong id resulted in the link pointing to a non-existent/incorrect group
    • Full fix would require a patch on the DB so temporarily just removed the link
  2. Group Comments now display the proper text
    • Originally group comments displayed as group broadcasts
    • Fixed an incorrect conditional in common-types.ts
  3. Group Comments link to the group is now correct
    • Originally group comments linked to a legacy part of the site that no longer exists
    • Link now properly points to the appropriate group

Updated Group Notifications: Group Notifications