search

eternaldensity / Sandcastle-Builder

xkcd: 1190: Time: The Game
Other
79 stars 65 forks source link

Classic broken with cloud sync #1390

Closed elswyyr closed 8 years ago

elswyyr commented 8 years ago

When attempting to run Classic.html, it fails with the error message "ReferenceError: GH is not defined options.js:134:4". Seems to be something related to cloud sync, but I don't know how that part of the code works.

erplsf commented 8 years ago

That's my part of the code. I'll try to look at it ASAP, thanks. On Dec 5, 2015 20:15, "elswyyr" notifications@github.com wrote:

When attempting to run Classic.html, it fails with the error message "ReferenceError: GH is not defined options.js:134:4". Seems to be something related to cloud sync, but I don't know how that part of the code works.

— Reply to this email directly or view it on GitHub https://github.com/eternaldensity/Sandcastle-Builder/issues/1390.

EPSIL0N commented 8 years ago

I think we ran into the same in the LL testing branch and the issue was as simple as the two references to gh.js and github.js are missing from the classic.html but I play with a layout so I can't say I tested much beyond it actually loading up and I don't think I've ever actually used the gh synch in either style.

elswyyr commented 8 years ago

Seems to be working after EPSIL0N's 4.0 pull.