eternaldensity / Sandcastle-Builder

xkcd: 1190: Time: The Game
Other
79 stars 65 forks source link

Memory leak in 4.04 in Google Chrome #1486

Open ReportingIn opened 7 years ago

ReportingIn commented 7 years ago

Notifications appear to be causing a memory leak of some kind in Google Chrome (Version 57.0.2987.133 (64-bit)). I've been able to idle in Sandcastle Builder with it open in a tab for months now, but after this update the memory usage is increasing quite a bit over time. It increases at a greatly accelerated if I use an auto-clicker. A fresh SB tab opens at roughly 85,000K memory usage, and after a minute without doing anything it goes up to roughly 102,000K. After a single minute (60 seconds) of using an auto-clicker the memory jumps all the way up to over 910,000K. This is not with infinite notifications being enabled.

I'm able to reproduce this in Incognito mode without any extensions enabled at all. I tried reproducing it in Firefox, but while memory does spike it only gets up to 165 MB or so. I attempted to reduce the number of notifications in the log for Chrome, but it does not appear to affect it.

Not sure what other information I can provide, but please let me know if you need anything further.

deterb commented 7 years ago

I can confirm that some sort of leak is happening. I enabled all of the memory related columns in Chrome's task manager and nothing but the "Memory" and "Private Memory" columns are spiked. Javascript memory is around 50K live memory, which isn't large enough to cover the 680,000K of memory being used. I'm only logging 20 notifications, and it's happening even when the notification pane is disabled.

Memory still rises when I click the picture, even when sand notifications are off as well.