search

eternaldensity / Sandcastle-Builder

xkcd: 1190: Time: The Game
Other
79 stars 65 forks source link

Fix redacted spoiler (the rick roll) #1525

Closed IHaveNoFunnyName closed 3 years ago

IHaveNoFunnyName commented 3 years ago

Updated the Beanish to point to HTTPS, which let the spoiler work again, but since the kitty gets painted every mNP it refreshes the iframe and it never actually you know, plays.

So now the spoiler is its own element that gets set to the kitty's location whenever it moves.

IHaveNoFunnyName commented 3 years ago

Ok so now there's two bugs left that I'm 'ok' with, or more likely that i'll fix later.

1) When the element the spoiler is in is toggled and the kitty jumps, the spoiler is displayed at 0,0 instead of its new location for 1 mNP 2) When the anchor is in a scrollable element, and is scrolled above or below the element, the spoiler positions itself in open space where the element "should" be. Only really effects the loot plane, if they don't have it paginated, and it appears in badges

E: And done. 2) still happens if it displays below the element, but I'd need the height of the element to fix that, tried getting it a couple of ways but the height it gave back was wrong & didn't update when I changed the elements height. Maybe I could find the id of the element, look it up in the currently active layout and pick the height there, but that seems way too involved.

IHaveNoFunnyName commented 3 years ago

Jeez I hope this isn't sending an email for every commit

eternaldensity commented 2 years ago

Fix a weird bug where the kitty wouldn't display a caged puzzle.

Don't think it did afaicr