search

eternaldensity / Sandcastle-Builder

xkcd: 1190: Time: The Game
Other
84 stars 68 forks source link

RRSR broken #889

Closed waveney closed 10 years ago

waveney commented 10 years ago

The latest Redacted changes break RRSR - when it is bought it's group has been set to blank rather than hpt. This line in this.randoiseTime is what breaks it, commenting it out has at least stopped the error mesage I suspect however this is not sufficient.

            //this.group = '';

See http://www.reddit.com/r/SandcastleBuilder/comments/20hb72/dord_not_unlocking/

LucidCrux commented 10 years ago

That can't be it, I basically just renamed the function and moved it inside Molpy.Redacted. That's actually what I did with pretty much all of the redacted stuff, just moved it. I'll do some hunting I guess.

waveney commented 10 years ago

I think the problem is that group has meaning for more than one type of object. By commenting it out it stopped generating errors, but I suspect this was supposed to set "group" on another object - I wonder if things are getting crosed.

LucidCrux commented 10 years ago

I'm not sure, the line before I moved it was Molpy.redactedGr = '';

I submitted a fix for things unlocking, not sure how it will affect the group crash thing, I don't see how it would. : /

waveney commented 10 years ago

I submitted a fix for things unlocking, not sure how it will affect the group crash thing, I don't see how it would. : /

Just merged it. I agree it does not look related. There is a save for this bug on Reddit - just click overcompensating and RRSR will appear in the shop.

LucidCrux commented 10 years ago

Yeah, messing with it now. I have no clue how it could be setting something elses group to '' but I'll keep looking.

LucidCrux commented 10 years ago

Yeah, that boost also somehow gets the toggle property... I still have no clue how though.

LucidCrux commented 10 years ago

found it, fix submitted

waveney commented 10 years ago

Thankyou