timothy1ee
commented
9 years ago :+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.
Here's a checklist of things that I'm looking for in this project. You should review the checklist, and make any changes to your project, if necessary.
- For the restaurant cell, note that you should move all unnecessarily public properties to the private class extension in the .m file. Override the default setter for the restaurant object and update the view objects there. For Swift, note that the subviews should be private and only updated in the Swift property observer.
- All screens in Storyboard and nibs should contain Auto Layout constraints. Make sure to resolve all the Auto Layout constraint warnings.
- In the filter view controller, make sure the cells are being recycled and dequeued and appropriately linked to the model. See this popular form library for an alternative to implementing forms manually.
- The restaurants view controller and the filters view controller should be connected via a custom filter delegate. This is a popular pattern for handling events between view controllers.
- Note: Connecting the filter view controller directly to a global filter settings is convenient, but the downside is if you cancel the filters, the values have already been saved.
This was a challenging assignment, congrats on completing it successfully!
My app is complete, please review. @codepathreview