search

eternaltyro / chef-aws-inspector

Chef cookbook to install and maintain AWS inspector
https://supermarket.chef.io/cookbooks/aws-inspector
MIT License
1 stars 8 forks source link

Testing improvements; package uninstall ordering change. #2

Closed don-code closed 7 years ago

don-code commented 7 years ago

This change makes three improvements:

  1. Running Foodcritic tests now disables the FC001 rule automatically, per README.md.
  2. As the AWS Inspector installer must run on an AWS instance, Test Kitchen now uses the kitchen-ec2 backend, instead of the kitchen-vagrant backend, to provision instances in EC2 for testing.
  3. A packaged agent gets removed before an agent is installed from the script. This prevents conflicts between the two during a converge.
eternaltyro commented 7 years ago

Merged. Thanks for the pull request and sorry for the delay.