search

eternaltyro / chef-aws-inspector

Chef cookbook to install and maintain AWS inspector
https://supermarket.chef.io/cookbooks/aws-inspector
MIT License
1 stars 8 forks source link

switch from specific attribute precedence to whatever chef resolves to #4

Closed majormoses closed 6 years ago

majormoses commented 6 years ago

Fixes #3

Also misc other styalistic (largely based on rubocop rulesets) changes.

Signed-off-by: Ben Abrams me@benabrams.it

majormoses commented 6 years ago

I have not yet tested this and I will have some time to test this tomorrow, the code should be sane though.

majormoses commented 6 years ago

Hmm I guess it is a breaking change unless we change the default to false...let me know if you want me to change that.

majormoses commented 6 years ago

I tested this and it works as expected, will await to hear back if you want me to change the default to false for inspector being enabled which keeps the backwards compatibility.

majormoses commented 6 years ago

I did not see any integration testing framework such as (server|in)spec in place or I would have written a test for it but I can verify it installed:

babrams@ip-10-55-142-7:~$ dpkg --get-selections | grep awsagent
awsagent                    install
awsagentkernelmodule-4.4.0-1047-aws     install
eternaltyro commented 6 years ago

Merged. Thanks.

majormoses commented 6 years ago

Awesome, if possible please let me know when you bump the version and release the new version to supermarket as I'd love to start using this.

eternaltyro commented 6 years ago

Cookbook uploaded. Added you as a collaborator on Supermarket too! Thanks a ton for the help.

majormoses commented 6 years ago

@eternaltyro if you are gonna add me as a collaborator on the supermarket could you add me as collaborator on github?

eternaltyro commented 6 years ago

@majormoses also done.