eternaltyro / cryptsetup

Since Google code is shuttering...
http://code.google.com/p/cryptsetup
GNU General Public License v2.0
0 stars 0 forks source link

Enh: Wording of passphrase prompts is inconsistent and confusing #145

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Impact:
Mild user confusion, lack of perception of quality

What steps will reproduce the problem?
1. # cryptsetup luksAddKey <device>
2. Output says "Enter any passphrase"
3. I'm adding a key, so I type the key I want to add, it doesn't work and I get 
confused and cry.

What is the expected output? What do you see instead?
I would expect the prompt to infer that cryptsetup would like a key that has 
previously been specified. I would suggest "Enter any existing passphrase"

What version of the product are you using? On what operating system?
cryptsetup 1.5.1

Please provide any additional information below.
In addition, I noticed that the "cryptsetup luksRemoveKey" prompt says "Enter 
LUKS passphrase to be deleted". None of the other prompts mention LUKS 
specifically, and I think it's unnecessary to mention LUKS. I would prefer no 
mention at all, but at least consistency gives a good quality perception.

Original issue reported on code.google.com by ch3...@googlemail.com on 8 Feb 2013 at 7:12

GoogleCodeExporter commented 9 years ago
yes, I agree with both notes, phrasing of prompts is not consistent.

I will review this soon, thanks.

Original comment by gmazyl...@gmail.com on 8 Feb 2013 at 7:25

GoogleCodeExporter commented 9 years ago
Changed in git tree so it is not more consistent, thanks.

http://code.google.com/p/cryptsetup/source/detail?r=fd5b88449a19e0b69e876296db87
d453052c8495#

Original comment by gmazyl...@gmail.com on 11 Feb 2013 at 1:59

GoogleCodeExporter commented 9 years ago
It is *now* more consistent of course :-)

Original comment by gmazyl...@gmail.com on 11 Feb 2013 at 2:00